From 2b989aeb7c9ca8e9b214b902e648d3de4fc45e7e Mon Sep 17 00:00:00 2001
From: Nathan Coad <nathan.coad@dell.com>
Date: Mon, 30 Oct 2023 09:48:32 +1100
Subject: [PATCH] tweak logging messages

---
 main.go | 29 ++++++++++++++++-------------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/main.go b/main.go
index 9f72dbc..0fdb19b 100644
--- a/main.go
+++ b/main.go
@@ -180,7 +180,7 @@ func processVMs(client *govmomi.Client) error {
 						sharingType := info.Sharing
 
 						if sharingType == "sharingMultiWriter" {
-							fmt.Printf("VM %s is using MultiWriter on disk %ss\n", vm.Name, diskLabel)
+							fmt.Printf("VM %s is using MultiWriter on disk %s\n", vm.Name, diskLabel)
 
 							result := MultiWriterResults{
 								VmName:      vm.Name,
@@ -389,6 +389,7 @@ func updateConfluencePage(api *goconfluence.API, vCenterHostname string, pageId
 */
 
 func main() {
+	var err error
 	// Command line flags
 	vURL := flag.String("url", "", "The URL of a vCenter server, eg https://server.domain.example/sdk")
 	vUser := flag.String("user", "", "The username to use when connecting to vCenter")
@@ -404,6 +405,18 @@ func main() {
 
 	flag.Parse()
 
+	// Print logs to file
+	/*
+		f, err := os.OpenFile("log.txt", os.O_RDWR|os.O_CREATE|os.O_APPEND, 0666)
+		if err != nil {
+			log.Fatalf("error opening file: %v", err)
+		}
+		defer f.Close()
+		log.SetOutput(f)
+	*/
+
+	fmt.Printf("Starting execution. Built on %s from sha1 %s\n", buildTime, sha1ver)
+
 	if len(*vURL) == 0 {
 		panic("Unable to connect to empty vCenter URL")
 	}
@@ -425,16 +438,6 @@ func main() {
 		*cToken = val
 	}
 
-	// Print logs to file
-	f, err := os.OpenFile("log.txt", os.O_RDWR|os.O_CREATE|os.O_APPEND, 0666)
-	if err != nil {
-		log.Fatalf("error opening file: %v", err)
-	}
-	defer f.Close()
-	log.SetOutput(f)
-
-	fmt.Printf("Starting execution. Built on %s from sha1 %s\n", buildTime, sha1ver)
-
 	// So we can convert vCenter UTC to our local timezone
 	fmt.Printf("Setting timezone to '%s'\n", *vTZ)
 	location, err = time.LoadLocation(*vTZ)
@@ -455,7 +458,7 @@ func main() {
 	}
 	vCenterHostname := u.Host
 
-	log.Printf("Connecting to vCenter %s\n", u)
+	fmt.Printf("Connecting to vCenter %s\n", u)
 	u.User = url.UserPassword(*vUser, *vPass)
 
 	ctx, cancel = context.WithCancel(context.Background())
@@ -472,7 +475,7 @@ func main() {
 	// Find scsi bus sharing and multi writer VMs
 	err = processVMs(c)
 	if err != nil {
-		log.Printf("Error processing list of VMs : %s\n", err)
+		fmt.Printf("Error processing list of VMs : %s\n", err)
 		os.Exit(1)
 	}