[ci skip] codex 5.3 review

internal/tasks/monitorVcenter.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"database/sql"
 	"errors"
-	"fmt"
 	"log/slog"
 	"strings"
 	"time"
@@ -16,103 +15,11 @@ import (
 	"github.com/vmware/govmomi/vim25/types"
 )
 
-// use gocron to check vcenters for VMs or updates we don't know about
+// RunVcenterPoll is intentionally disabled.
+// The legacy inventory polling flow has been retired in favor of hourly snapshots.
 func (c *CronTask) RunVcenterPoll(ctx context.Context, logger *slog.Logger) error {
-	startedAt := time.Now()
-	defer func() {
-		logger.Info("Vcenter poll job finished", "duration", time.Since(startedAt))
-	}()
-	var matchFound bool
-
-	// reload settings in case vcenter list has changed
-	c.Settings.ReadYMLSettings()
-
-	for _, url := range c.Settings.Values.Settings.VcenterAddresses {
-		c.Logger.Debug("connecting to vcenter", "url", url)
-		vc := vcenter.New(c.Logger, c.VcCreds)
-		vc.Login(url)
-
-		// Get list of VMs from vcenter
-		vcVms, err := vc.GetAllVmReferences()
-
-		// Get list of VMs from inventory table
-		c.Logger.Debug("Querying inventory table")
-		results, err := c.Database.Queries().GetInventoryByVcenter(ctx, url)
-		if err != nil {
-			c.Logger.Error("Unable to query inventory table", "error", err)
-			return err
-		}
-
-		if len(results) == 0 {
-			c.Logger.Error("Empty inventory results")
-			return fmt.Errorf("Empty inventory results")
-		}
-
-		// Iterate VMs from vcenter and see if they were in the database
-		for _, vm := range vcVms {
-			matchFound = false
-
-			// Skip any vCLS VMs
-			if strings.HasPrefix(vm.Name(), "vCLS-") {
-				//c.Logger.Debug("Skipping internal VM", "vm_name", vm.Name())
-				continue
-			}
-
-			// TODO - should we compare the UUID as well?
-			for _, dbvm := range results {
-				if dbvm.VmId.String == vm.Reference().Value {
-					//c.Logger.Debug("Found match for VM", "vm_name", dbvm.Name, "id", dbvm.VmId.String)
-					matchFound = true
-
-					// Get the full VM object
-					vmObj, err := vc.ConvertObjToMoVM(vm)
-					if err != nil {
-						c.Logger.Error("Failed to find VM in vcenter", "vm_id", dbvm.VmId.String, "error", err)
-						continue
-					}
-
-					if vmObj.Config == nil {
-						c.Logger.Error("VM has no config properties", "vm_id", dbvm.VmId.String, "vm_name", vmObj.Name)
-						continue
-					}
-
-					// Check that this is definitely the right VM
-					if dbvm.VmUuid.String == vmObj.Config.Uuid {
-						// TODO - compare database against current values, create update record if not matching
-						err = c.UpdateVmInventory(vmObj, vc, ctx, dbvm)
-					} else {
-						c.Logger.Error("VM uuid doesn't match database record", "vm_name", dbvm.Name, "id", dbvm.VmId.String, "vc_uuid", vmObj.Config.Uuid, "db_uuid", dbvm.VmUuid.String)
-					}
-
-					break
-				}
-			}
-
-			if !matchFound {
-				c.Logger.Debug("Need to add VM to inventory table", "MoRef", vm.Reference())
-				vmObj, err := vc.ConvertObjToMoVM(vm)
-				if err != nil {
-					c.Logger.Error("Received error getting vm maangedobject", "error", err)
-					continue
-				}
-
-				// retrieve VM properties and insert into inventory
-				err = c.AddVmToInventory(vmObj, vc, ctx)
-				if err != nil {
-					c.Logger.Error("Received error with VM add", "error", err)
-					continue
-				}
-
-				// add sleep to slow down mass VM additions
-				utils.SleepWithContext(ctx, (10 * time.Millisecond))
-			}
-		}
-		c.Logger.Debug("Finished checking vcenter", "url", url)
-		_ = vc.Logout(ctx)
-	}
-
-	c.Logger.Debug("Finished polling vcenters")
-
+	_ = ctx
+	logger.Info("legacy vcenter polling task is disabled")
 	return nil
 }