updates

internal/vcenter/vcenter.go

@@ -6,7 +6,6 @@ import (
 	"log"
 	"log/slog"
 	"net/url"
-	"os"
 	"path"
 	"strings"
 
@@ -30,6 +29,7 @@ type Vcenter struct {
 type VcenterLogin struct {
 	Username string
 	Password string
+	Insecure bool
 }
 
 type VmProperties struct {
@@ -51,13 +51,6 @@ func New(logger *slog.Logger, creds *VcenterLogin) *Vcenter {
 }
 
 func (v *Vcenter) Login(vUrl string) error {
-	var insecure bool
-
-	// TODO - fix this
-	insecureString := os.Getenv("VCENTER_INSECURE")
-	//username := os.Getenv("VCENTER_USERNAME")
-	//password := os.Getenv("VCENTER_PASSWORD")
-
 	// Connect to vCenter
 	u, err := soap.ParseURL(vUrl)
 	if err != nil {
@@ -74,11 +67,7 @@ func (v *Vcenter) Login(vUrl string) error {
 		}
 	*/
 
-	if insecureString == "true" {
-		insecure = true
-	}
-
-	c, err := govmomi.NewClient(v.ctx, u, insecure)
+	c, err := govmomi.NewClient(v.ctx, u, v.credentials.Insecure)
 	if err != nil {
 		v.Logger.Error("Unable to connect to vCenter", "error", err)
 		return fmt.Errorf("unable to connect to vCenter : %s", err)