nathan/vctp2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enhance snapshot handling by backfilling provisioned disk data and updating backfill logic
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
Nathan Coad
2026-02-13 16:17:56 +11:00
parent c446638eac
commit 6fbd6bc9d2
4 changed files with 38 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
internal/tasks/inventorySnapshots.go
View File

@@ -762,6 +762,21 @@ func snapshotFromVM(ctx context.Context, dbConn *sqlx.DB, vmObject *mo.VirtualMa
}
}
// Some VMs can be returned without complete virtual disk device metadata.
// Fall back to summary storage (committed + uncommitted) when available.
if !row.ProvisionedDisk.Valid && vmObject.Summary.Storage != nil {
provisionedBytes := vmObject.Summary.Storage.Committed
if vmObject.Summary.Storage.Uncommitted > 0 {
provisionedBytes += vmObject.Summary.Storage.Uncommitted
}
if provisionedBytes > 0 {
row.ProvisionedDisk = sql.NullFloat64{
Float64: float64(provisionedBytes) / 1024.0 / 1024.0 / 1024.0,
Valid: true,
}
}
}
if vmObject.Runtime.PowerState == "poweredOff" {
row.PoweredOn = "FALSE"
} else {
@@ -930,7 +945,7 @@ func snapshotFromVM(ctx context.Context, dbConn *sqlx.DB, vmObject *mo.VirtualMa
}
}
if dbConn != nil && needsSnapshotBackfill(row) {
if dbConn != nil && (needsSnapshotBackfill(row) || !row.ProvisionedDisk.Valid) {
if backfillSnapshotRowFromHourlyCache(ctx, dbConn, &row) && vc.Logger != nil {
vc.Logger.Debug("backfilled sparse VM snapshot row from hourly cache", "vm_id", row.VmId.String, "name", row.Name, "vcenter", row.Vcenter)
}
@@ -957,7 +972,6 @@ func snapshotFromVM(ctx context.Context, dbConn *sqlx.DB, vmObject *mo.VirtualMa
func needsSnapshotBackfill(row InventorySnapshotRow) bool {
return !row.CreationTime.Valid ||
!row.ProvisionedDisk.Valid ||
!row.VcpuCount.Valid ||
!row.RamGB.Valid ||
!row.Cluster.Valid ||