improve checks

models/secret.go

@@ -44,6 +44,7 @@ func (s *Secret) SaveSecret() (*Secret, error) {
 	return s, nil
 }
 
+// Returns all matching secrets, up to caller to determine how to deal with multiple results
 func GetSecrets(s *Secret) ([]Secret, error) {
 	var err error
 	var rows *sqlx.Rows
@@ -52,6 +53,7 @@ func GetSecrets(s *Secret) ([]Secret, error) {
 	fmt.Printf("GetSecret querying values '%v'\n", s)
 
 	// Determine whether to query for a specific device or a category of devices
+	// Prefer querying device name than category
 	if s.DeviceName != "" {
 		rows, err = db.Queryx("SELECT * FROM secrets WHERE DeviceName LIKE ? AND RoleId = ?", s.DeviceName, s.RoleId)
 	} else if s.DeviceCategory != "" {
@@ -62,8 +64,6 @@ func GetSecrets(s *Secret) ([]Secret, error) {
 		return secretResults, err
 	}
 
-	// TODO - do we want to generate an error if the query returns more than one result?
-
 	if err != nil {
 		fmt.Printf("GetSecret error executing sql record : '%s'\n", err)
 		return secretResults, err